Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPIKE Inline validation #1113

Closed

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Oct 16, 2023

Issue #1068

DO NOT MERGE

This PR is only for investigative purposes

@GuySartorelli
Copy link
Member

There's so much going on here it's hard to see what's doing what. Can you please add a few notes in the PR description explaining what all this PR is doing?

@emteknetnz
Copy link
Member Author

I don't think this PR is worth peer reviewing, it's not in a good state and it's not complete. It's not meant to be merged, it's kind of just a dumping ground for code I used to do investigation

@GuySartorelli
Copy link
Member

Is there anything in this PR that's useful for understanding and/or evaluating the high level approach you're recommending in the issue? Currently the issue is more of an info dump than a "this is the recommended approach" so it's a bit hard to follow from that angle.

@GuySartorelli
Copy link
Member

Closing this for now - we may end up copying some bits from this when we implement this validation in #329 but it likely won't use this exact PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants